Skip to content

Comments

Output alert applayer v22.1#10370

Closed
catenacyber wants to merge 3 commits intoOISF:masterfrom
catenacyber:output-alert-applayer-v22.1
Closed

Output alert applayer v22.1#10370
catenacyber wants to merge 3 commits intoOISF:masterfrom
catenacyber:output-alert-applayer-v22.1

Conversation

@catenacyber
Copy link
Contributor

Link to redmine tickets:
https://redmine.openinfosecfoundation.org/issues/3827
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053

Describe changes:

  • output: unify boilerplate code (trying to become a lines-of-code neutral contributor to Suricata ;-) and rising the percentage of rust files )
  • output/dns: do not add empty app-layer metadata
  • dnp3: restrict function scope to one file

#10319 rebased (to get a QA rerun)

does not need SV PR

@codecov
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9fe00ff) 82.52% compared to head (745ad37) 82.53%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #10370    +/-   ##
========================================
  Coverage   82.52%   82.53%            
========================================
  Files         978      966    -12     
  Lines      272148   271762   -386     
========================================
- Hits       224595   224292   -303     
+ Misses      47553    47470    -83     
Flag Coverage Δ
fuzzcorpus 63.70% <80.15%> (+0.11%) ⬆️
suricata-verify 61.83% <98.47%> (-0.05%) ⬇️
unittests 62.90% <36.64%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 101 112 110.89%

Pipeline 18456

@catenacyber catenacyber mentioned this pull request Feb 14, 2024
@catenacyber
Copy link
Contributor Author

Rebased in #10465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants